[BasicInformation] fetch data via a delegate#43569
Draft
andy31415 wants to merge 14 commits intoproject-chip:masterfrom
Draft
[BasicInformation] fetch data via a delegate#43569andy31415 wants to merge 14 commits intoproject-chip:masterfrom
andy31415 wants to merge 14 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Basic Information cluster to fetch data via a delegate instead of directly accessing DeviceInstanceInfoProvider and ConfigurationManager. This is a good architectural improvement that decouples the cluster logic from the platform-specific data providers. The changes are well-implemented across the cluster, its tests, and example applications. I have a few suggestions for improvement, mainly regarding a test mock's behavior and some dead code removal.
src/app/clusters/basic-information/DeviceLayerBasicInformationDelegate.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/basic-information/DeviceLayerBasicInformationDelegate.h
Outdated
Show resolved
Hide resolved
|
PR #43569: Size comparison from 3d6c065 to d8fb3aa Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #43569: Size comparison from 3d6c065 to ab56f8b Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #43569: Size comparison from 3d6c065 to 43c85d5 Full report (12 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, realtek, stm32)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43569 +/- ##
==========================================
- Coverage 54.07% 54.00% -0.07%
==========================================
Files 1548 1551 +3
Lines 106701 106740 +39
Branches 13309 13321 +12
==========================================
- Hits 57699 57650 -49
- Misses 49002 49090 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #43569: Size comparison from 3d6c065 to b1d462d Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43569: Size comparison from 3d6c065 to 4f50ce2 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is similar to #43511 however it fetches data via a delegate instead of using templates.
This is to assess flash overhead of delegates.
Testing
CI will validate. I adjusted unit tests.